Proposal: Add more compile-time asserts to expose inconsistencies. - Mailing list pgsql-hackers

From Smith, Peter
Subject Proposal: Add more compile-time asserts to expose inconsistencies.
Date
Msg-id 201DD0641B056142AC8C6645EC1B5F62014B8E8030@SYD1217
Whole thread Raw
Responses Re: Proposal: Add more compile-time asserts to exposeinconsistencies.
List pgsql-hackers
Dear Hackers,

I have identified some OSS code where more compile-time asserts could be added.

Mostly these are asserting that arrays have the necessary length to accommodate the enums that are used to index into
them.

In general the code is already commented with warnings such as:
* "If you add a new entry, remember to ..."
* "When modifying this enum, update the table in ..."
* "Display names for enums in ..."
* etc.

But comments can be accidentally overlooked, so adding the compile-time asserts can help eliminate human error.

Please refer to the attached patch.

Kind Regards,
Peter Smith
---
Fujitsu Australia

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: pgbench - allow to create partitioned tables
Next
From: Amit Khandekar
Date:
Subject: Re: logical decoding : exceeded maxAllocatedDescs for .spill files