Re: pg_waldump and PREPARE - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_waldump and PREPARE
Date
Msg-id 20191111071602.GA1418@paquier.xyz
Whole thread Raw
In response to Re: pg_waldump and PREPARE  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: pg_waldump and PREPARE  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Mon, Nov 11, 2019 at 01:21:28PM +0900, Fujii Masao wrote:
> Thanks for the review! You are right.
> I fixed this issue in the attached patch.

The proposed format looks fine to me.  I have just one comment.  All
three callers of standby_desc_invalidations() don't actually need to
print any data if there are zero messages, so you can simplify a bit
xact_desc_commit() and xact_desc_prepare() regarding the check on
parsed.nmsgs, no?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] Block level parallel vacuum
Next
From: Dilip Kumar
Date:
Subject: Re: cost based vacuum (parallel)