Re: pg_waldump erroneously outputs newline for FPWs, and anotherminor bug - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_waldump erroneously outputs newline for FPWs, and anotherminor bug
Date
Msg-id 20191030002621.GB1590@paquier.xyz
Whole thread Raw
In response to Re: pg_waldump erroneously outputs newline for FPWs, and anotherminor bug  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: pg_waldump erroneously outputs newline for FPWs, and anotherminor bug
List pgsql-hackers
On Tue, Oct 29, 2019 at 04:42:07PM -0700, Peter Geoghegan wrote:
> The same commit from Heikki omitted one field from that record, for no
> good reason. I backpatched a bugfix to the output format for nbtree
> page splits a few weeks ago, fixing that problem. I agree that we
> should also backpatch this bugfix.

The output format of pg_waldump may matter for some tools, like
Jehan-Guillaume's PAF [1], but I am ready to bet that any tools like
that just skip any noise newlines, so +1 for a backpatch.

I am adding Jehan-Guillaume in CC just in case.

[1]: https://github.com/ClusterLabs/PAF
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Make StringInfo available to frontend code.
Next
From: Michael Paquier
Date:
Subject: Re: Typos and inconsistencies in code