Re: Online checksums patch - once again - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Online checksums patch - once again
Date
Msg-id 20190926194828.GA17211@alvherre.pgsql
Whole thread Raw
In response to Online checksums patch - once again  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Online checksums patch - once again
List pgsql-hackers
On 2019-Aug-26, Magnus Hagander wrote:

> OK, let's try this again :)
> 
> This is work mainly based in the first version of the online checksums
> patch, but based on top of Andres WIP patchset for global barriers (
> https://www.postgresql.org/message-id/20181030051643.elbxjww5jjgnjaxg%40alap3.anarazel.de
> )
> 
> Andres patch has been enhanced with wait events per
> https://www.postgresql.org/message-id/CABUevEwy4LUFqePC5YzanwtzyDDpYvgrj6R5WNznwrO5ouVg1w%40mail.gmail.com
> .

Travis says your SGML doesn't compile (maybe you just forgot to "git
add" and edit allfiles.sgml?):

/usr/bin/xmllint --path . --noout --valid postgres.sgml
reference.sgml:287: parser error : Entity 'pgVerifyChecksums' not defined
   &pgVerifyChecksums;
                      ^
reference.sgml:295: parser error : chunk is not well balanced
postgres.sgml:231: parser error : Failure to process entity reference
 &reference;
            ^
postgres.sgml:231: parser error : Entity 'reference' not defined
 &reference;
            ^

Other than bots, this patch doesn't seem to have attracted any reviewers
this time around.  Perhaps you need to bribe someone?  (Maybe "how sad
your committer SSH key stopped working" would do?)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions
Next
From: Bruce Momjian
Date:
Subject: Re: pg_upgrade fails with non-standard ACL