Re: [HACKERS] [PATCH] pageinspect function to decode infomasks - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
Date
Msg-id 20190917040618.GD1660@paquier.xyz
Whole thread Raw
In response to Re: [HACKERS] [PATCH] pageinspect function to decode infomasks  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
List pgsql-hackers
On Tue, Sep 17, 2019 at 09:23:45AM +0530, Amit Kapila wrote:
> We always return a single tuple/record from this function, so do we
> really need to return SETOF record or just returning record is
> sufficient?

Right (with the doc update).

> If you want to use the same size array, then you might want to just
> memset the previous array rather than first freeing it and then again
> allocating it.  This is not a big point, so any which way is fine.

Sure.  This is less expensive though, so changed it the way you
are suggesting on my local branch.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [HACKERS] [PATCH] pageinspect function to decode infomasks
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] CLUSTER command progress monitor