On 2019-Sep-16, Michael Paquier wrote:
> On Mon, Sep 16, 2019 at 11:46:16AM +0530, Amit Kapila wrote:
> > I don't see much use of separating information for infomask and infomask2.
>
> Okay, using two separate columns leads to the attached. Any thoughts?
> This also includes a fix for cases with IS_LOCKED_ONLY and UPGRADED.
I like how it looks in the expected test output. Didn't review the code
closely, but it looks reasonable in a quick glance.
Whitespace nitpick: pgindent will do something very annoying with this:
> + PG_RETURN_DATUM(
> + HeapTupleGetDatum(heap_form_tuple(tupdesc, values, nulls)));
I suggest to split the line in the first comma, not in the parens.
> + Combined flags include for example <literal>HEAP_XMIN_FROZEN</literal>
> + which is defined as a set of <literal>HEAP_XMIN_COMMITTED</literal>
> + and <literal>HEAP_XMIN_INVALID</literal>.
I suggest something like "Combined flags are displayed for source-level
macros that take into account the value of more than one raw bit, such
as HEAP_XMIN_FROZEN". (We probably don't want an exhaustive list, which
becomes annoying to maintain; users can refer to the source file.)
There's a typo "bites" in a comment.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
