Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEMSET. - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEMSET.
Date
Msg-id 20190828063440.GI1965@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Tue, Aug 27, 2019 at 11:38:28PM -0400, Tom Lane wrote:
> Yeah, it might be a good idea to make a sweep to see what other tests
> should be using safe_psql.

I found more of these while browsing all the tests, so I am just going
to start a new thread with a patch.

> Or, more radically, we could think about redefining PostgresNode::psql
> to complain about errors, and you have to use something else if you
> want it not to?

Not sure about redesigning that as it has been around for a couple of
years now, and that would mean perhaps a third wrapper on top of
PostgresNode::psql.
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.
Next
From: Thomas Munro
Date:
Subject: pgsql: Avoid catalog lookups in RelationAllowsEarlyPruning().