Re: Is ParsePrepareRecord dead function - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Is ParsePrepareRecord dead function
Date
Msg-id 20190729210422.GA23667@alvherre.pgsql
Whole thread Raw
In response to Re: Is ParsePrepareRecord dead function  (vignesh C <vignesh21@gmail.com>)
Responses Re: Is ParsePrepareRecord dead function  (Amit Kapila <amit.kapila16@gmail.com>)
Re: Is ParsePrepareRecord dead function  (vignesh C <vignesh21@gmail.com>)
List pgsql-hackers
On 2019-Jul-29, vignesh C wrote:

> On Mon, Jul 29, 2019 at 8:24 PM Robert Haas <robertmhaas@gmail.com> wrote:
> >
> > On Mon, Jul 29, 2019 at 4:10 AM vignesh C <vignesh21@gmail.com> wrote:
> > > I could not locate the caller of ParsePrepareRecord function in twophase.c.
> > > Any idea how it gets called?
> > > or
> > > Is it a dead function?
> >
> > It looks like it's not only dead, but stillborn.  Commit
> > 1eb6d6527aae264b3e0b9c95aa70bb7a594ad1cf introduced it but without
> > introducing any code that called it, and nothing has changed since
> > then.
>
> I feel the code can be safely removed.
> Patch for the same is attached.

I think there's a patch from Fujii Masao that touches that?  Might be
premature to remove it.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: TopoSort() fix
Next
From: Peter Geoghegan
Date:
Subject: Re: should there be a hard-limit on the number of transactionspending undo?