Re: Table AM callbacks referring to heap in declarations (+typos) - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Table AM callbacks referring to heap in declarations (+typos)
Date
Msg-id 20190601194311.v4x5iaylp7gue4sm@alap3.anarazel.de
Whole thread Raw
In response to Re: Table AM callbacks referring to heap in declarations (+typos)  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Table AM callbacks referring to heap in declarations (+typos)
List pgsql-hackers
On 2019-06-01 15:37:43 -0400, Michael Paquier wrote:
> On Sat, Jun 01, 2019 at 12:22:10PM -0700, Andres Freund wrote:
> > On 2019-06-01 15:09:46 -0400, Michael Paquier wrote:
> >> While going through the table AM callbacks, I have bumped into a
> >> couple of references to heap.  I think that we should make that more
> >> generic by using the term "table" as done when opening relations and
> >> such.  Attached is a cleanup patch.
> > 
> > I'm unbothered by this, but I'm also not opposed to changing this. It's
> > largely just keeping the previous code / comment.
> > 
> >> While on it, I found a set of typos which looked like a copy-pasto
> >> which got spread => "index_nfo".
> > 
> > Yea, we should fix this.
> 
> Thanks.  Do you mind if I fix both then?

I don't mind at all (although it's imo not a fix for the s/heap/table)!

- Andres



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: psql completion bugs with access methods
Next
From: Andres Freund
Date:
Subject: Re: psql completion bugs with access methods