Re: Tighten error control for OpenTransientFile/CloseTransientFile - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Tighten error control for OpenTransientFile/CloseTransientFile
Date
Msg-id 20190308010005.GA28241@alvherre.pgsql
Whole thread Raw
In response to Re: Tighten error control for OpenTransientFile/CloseTransientFile  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Tighten error control for OpenTransientFile/CloseTransientFile
List pgsql-hackers
On 2019-Mar-07, Michael Paquier wrote:

>  #else
> -    close(fd);
> +    if (close(fd))
> +    {
> +        fprintf(stderr, _("%s: could not close file \"%s\": %s"),
> +                progname, ControlFilePath, strerror(errno));
> +        exit(EXIT_FAILURE);
> +    }
>  #endif

I think this one needs a terminating \n.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Update does not move row across foreign partitions in v11
Next
From: Michael Paquier
Date:
Subject: Re: pg_basebackup against older server versions