Re: pgsql: pg_regress: Don't use absolute paths for the diff - Mailing list pgsql-committers

From Stephen Frost
Subject Re: pgsql: pg_regress: Don't use absolute paths for the diff
Date
Msg-id 20190223003936.GF6197@tamriel.snowman.net
Whole thread Raw
In response to Re: pgsql: pg_regress: Don't use absolute paths for the diff  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: pg_regress: Don't use absolute paths for the diff  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-committers
Greetings,

* Michael Paquier (michael@paquier.xyz) wrote:
> On Fri, Feb 22, 2019 at 03:26:35PM -0800, Andres Freund wrote:
> > that's useless, because I can't trivially copy the result file into the
> > expected file anymore. I have to figure out where in the tree it
> > is. Which isn't exactly predictable, between the different tests we
> > have as they locate their test results in different places.
>
> I haven't paid much attention to this commit, but the new behavior is
> likely something which will become annoying in some not-so-far future
> for me as well.
>
> > This is a bad idea.
>
> +1.

Yeah, same here, if I can't easily copy the result file into the
expected file, I'm going to be *most* annoyed...

Thanks!

Stephen

Attachment

pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Fix incorrect function reference in comment of twophase.c
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Revert "pg_regress: Don't use absolute paths for the diff"