Re: pgsql: pg_regress: Don't use absolute paths for the diff - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: pg_regress: Don't use absolute paths for the diff
Date
Msg-id 20190222233419.GB8725@paquier.xyz
Whole thread Raw
In response to Re: pgsql: pg_regress: Don't use absolute paths for the diff  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: pg_regress: Don't use absolute paths for the diff  (Stephen Frost <sfrost@snowman.net>)
List pgsql-committers
On Fri, Feb 22, 2019 at 03:26:35PM -0800, Andres Freund wrote:
> that's useless, because I can't trivially copy the result file into the
> expected file anymore. I have to figure out where in the tree it
> is. Which isn't exactly predictable, between the different tests we
> have as they locate their test results in different places.

I haven't paid much attention to this commit, but the new behavior is
likely something which will become annoying in some not-so-far future
for me as well.

> This is a bad idea.

+1.
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: pg_regress: Don't use absolute paths for the diff
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix incorrect function reference in comment of twophase.c