Re: minor fix in CancelVirtualTransaction - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: minor fix in CancelVirtualTransaction
Date
Msg-id 201901112135.avniptip2qpj@alvherre.pgsql
Whole thread Raw
In response to Re: minor fix in CancelVirtualTransaction  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: minor fix in CancelVirtualTransaction  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 2019-Jan-04, Peter Eisentraut wrote:

> Your reasoning seems correct to me.
> 
> Maybe add a code comment along the lines of "once we have found the
> right ... we don't need to check the remaining ...".
> 
> Or, you can make this even more clear by comparing the backendId
> directly with the proc entry:

I did both (the second idea was a non-obvious very nice cleanup --
thanks).  Patch attached.

However, now I realize that this code is not covered at all, so I'll put
this patch to sleep until I write some test for it.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Three animals fail test-decoding-check on REL_10_STABLE
Next
From: Tom Lane
Date:
Subject: Re: Three animals fail test-decoding-check on REL_10_STABLE