Re: pgsql: Remove function names from error messages - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Remove function names from error messages
Date
Msg-id 20181219234103.GC27104@paquier.xyz
Whole thread Raw
In response to pgsql: Remove function names from error messages  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgsql: Remove function names from error messages  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: pgsql: Remove function names from error messages  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-committers
On Wed, Dec 19, 2018 at 05:53:48PM +0000, Alvaro Herrera wrote:
> Remove function names from error messages
>
> They are not necessary, and having them there gives useless work for
> translators.

I am spotting a couple of extra ones for functions:
src/backend/access/transam/xlog.c:
(errmsg("pg_stop_backup cleanup done, waiting for required WAL segments
to be archived")));

src/backend/access/transam/xlog.c:
(errmsg("pg_stop_backup still waiting for all required WAL segments to
be archived (%d seconds elapsed)",

Perhaps these could be improved as well?
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Make type "name" collation-aware.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Remove function names from error messages