Can we remove the #fdef UNUSED code from nbtxlog.c - Mailing list pgsql-hackers

From Andres Freund
Subject Can we remove the #fdef UNUSED code from nbtxlog.c
Date
Msg-id 20181213232815.qsfjdhp6zfo2itks@alap3.anarazel.de
Whole thread Raw
Responses Re: Can we remove the #fdef UNUSED code from nbtxlog.c  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi,

nbtxlog.c has a fairly large section of code commented out with #ifdef
UNUSED. With a node justifying that with:

+    * This section of code is thought to be no longer needed, after
+    * analysis of the calling paths. It is retained to allow the code
+    * to be reinstated if a flaw is revealed in that thinking.

That seems much better addressed by git revert/git log.  Having a
comment explaining facts that aren't true anymore is just plain
confusing.

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0
Next
From: Robert Haas
Date:
Subject: Re: Remove Deprecated Exclusive Backup Mode