Re: Removal of unnecessary CommandCounterIncrement() when doing ONCOMMIT DELETE ROWS - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Removal of unnecessary CommandCounterIncrement() when doing ONCOMMIT DELETE ROWS
Date
Msg-id 20181113000457.GA1336@paquier.xyz
Whole thread Raw
In response to Re: Removal of unnecessary CommandCounterIncrement() when doing ONCOMMIT DELETE ROWS  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Mon, Nov 12, 2018 at 01:19:31PM -0300, Alvaro Herrera wrote:
> On 2018-Nov-09, Michael Paquier wrote:
>> When doing a set of ON COMMIT DELETE ROWS actions for relations, there
>> is a CCI happening after each truncation:
>
> Right, but note that this is not a loop so it's only one CCI, not one
> per relation.  (This doesn't seem a big deal either way, but I see no
> reason to have that line there.)

This looks like a lack of caffeine from my side.

>> And I think that I agree with that, because visibly this applies to
>> index rebuilds but in those cases CCIs are happening locally.  So I
>> think that we can get rid of that, and I suggest to remove it only on
>> HEAD only of course.
>
> +1

Thanks Álvaro for the input, I have committed the change.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation
Next
From: Michael Paquier
Date:
Subject: Re: doc fix for pg_stat_activity.backend_type