Re: TAP tests for pg_verify_checksums - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: TAP tests for pg_verify_checksums
Date
Msg-id 20181006114648.GA1642@paquier.xyz
Whole thread Raw
In response to Re: TAP tests for pg_verify_checksums  (Michael Banck <michael.banck@credativ.de>)
Responses Re: TAP tests for pg_verify_checksums  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On Fri, Oct 05, 2018 at 01:38:05PM +0200, Michael Banck wrote:
> It's too late for v11 though at this point I guess?

Unfortunately yes.

> I think it would be easy to also test the -r command-line option, as we
> already create a table.

Good idea.  Let's add this test.

> That comment should read 'that checksums are enabled', right?

Indeed.  Fixed.

> Otherwise, LGTM and I've tested it without finding any problems.

What do you think about the updated version attached?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Problem while setting the fpw with SIGHUP
Next
From: Amit Kapila
Date:
Subject: Re: now() vs transaction_timestamp()