Re: Mention FK creation take ShareRowExclusiveLock on referencedtable - Mailing list pgsql-docs

From Michael Paquier
Subject Re: Mention FK creation take ShareRowExclusiveLock on referencedtable
Date
Msg-id 20180919025302.GF1650@paquier.xyz
Whole thread Raw
In response to Mention FK creation take ShareRowExclusiveLock on referenced table  (Adrien NAYRAT <adrien.nayrat@anayrat.info>)
Responses Re: Mention FK creation take ShareRowExclusiveLock on referencedtable
List pgsql-docs
On Tue, Sep 18, 2018 at 12:32:54PM +0200, Adrien NAYRAT wrote:
> A few days ago I was surprised a CREATE TABLE containing FK constraint was
> stuck due to an automatic vacuum freeze (which took ShareUpdateExclusiveLock
> if I remember) on referenced table.

Right.  See the top of vacuum_rel() where lmode is set.

> After digging into the code I found theses lines in tablecmds.c :
>
> /*
>  * Grab ShareRowExclusiveLock on the pk table, so that someone doesn't
>  * delete rows out from under us.
>  */
>
> Maybe it should be documented in theses pages?
>
> https://www.postgresql.org/docs/current/static/sql-createtable.html
> https://www.postgresql.org/docs/current/static/sql-altertable.html
>
> If you agree I can send a patch.

That looks like a good idea.  Are you thinking about adding a comment
about that in "ADD table_constraint" for the ALTER TABLE page, and in
"FOREIGN KEY" for the CREATE TABLE page?
--
Michael

Attachment

pgsql-docs by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Ambiguity in restore_command for recovery.conf
Next
From: Tom Lane
Date:
Subject: Re: Punctuation error