Re: Non-reserved replication slots and slot advancing - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Non-reserved replication slots and slot advancing
Date
Msg-id 20180710075907.GK1661@paquier.xyz
Whole thread Raw
In response to Re: Non-reserved replication slots and slot advancing  (Andres Freund <andres@anarazel.de>)
Responses Re: Non-reserved replication slots and slot advancing  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Tue, Jul 10, 2018 at 12:26:30AM -0700, Andres Freund wrote:
> Why is the ReplicationSlotRelease() needed here? Souldn't the error
> handling code do so automatically?

Oh, indeed.  I didn't know that PostgresMain was doing some cleanup
here.  There is a second place where this can be removed, which comes
from the original commit which added the advance function.  An updated
version is attached.  Do you have other comments?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: 杨杰
Date:
Subject: user-friendliness improvement of pageinspect
Next
From: "Iwata, Aya"
Date:
Subject: RE: hostorder and failover_timeout for libpq