Re: [GSoC] current working status - Mailing list pgsql-hackers

From Aleksander Alekseeev
Subject Re: [GSoC] current working status
Date
Msg-id 20180615113358.0214b4b4@e733.localdomain
Whole thread Raw
In response to Re: [GSoC] current working status  (Charles Cui <charles.cui1984@gmail.com>)
Responses Re: [GSoC] current working status
List pgsql-hackers
Hello Charles,

> The repo currently can be build on my mac. You can check it out.
> Also I am working on the CI config to monitor each commit.

Tests pass on Arch Linux with PostgreSQL 11 and Ubuntu 16.04 with
PostgreSQL 9.6. However there is a name conflict in case of PostgreSQL
11: https://afiskon.ru/s/7a/fe681b17f0_paste.txt I suggest to rename
the procedure to `convert_int8_to_char`.

Also GCC still generates a lot of warnings (see my previous message).
I would advise to fix all these warnings, otherwise you can miss a
really important warning. Ideally, the code should be compiled with
-Wall flag.

-- 
Best regards,
Aleksander Alekseev


pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: Memory leaks in BufFileOpenShared()
Next
From: Masahiko Sawada
Date:
Subject: Re: Index maintenance function for BRIN doesn't check RecoveryInProgress()