Postgres Pro
Downloads
Home   >   mailing lists

Re: bugfifx: a minor mistake in brin_inclusion.c comment - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: bugfifx: a minor mistake in brin_inclusion.c comment
Date
Msg-id 20180326151126.6bouh22l4n3ynwcy@alvherre.pgsql
Whole thread Raw
In response to bugfifx: a minor mistake in brin_inclusion.c comment  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
List pgsql-hackers
Tree view 
Tomas Vondra wrote:
> Hi,
> 
> while looking at brin_inclusion.c, I've noticed that the comment about
> INCLUSION_UNMERGEABLE and INCLUSION_CONTAINS_EMPTY uses incorrect values
> (1 instead of 2). Attached is a simple fix.

Uh, yeah, this is wrong.

> But perhaps it would be better to use the constants in the comment.

I fixed it like this, which seems neater.

Thanks!

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] MERGE SQL Statement for PG11
Next
From: Tom Lane
Date:
Subject: Re: Direct converting numeric types to bool