Re: CURRENT OF causes an error when IndexOnlyScan is used - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: CURRENT OF causes an error when IndexOnlyScan is used
Date
Msg-id 20180220095252.GA18315@e733.localdomain
Whole thread Raw
In response to Re: CURRENT OF causes an error when IndexOnlyScan is used  (Anastasia Lubennikova <a.lubennikova@postgrespro.ru>)
Responses Re: CURRENT OF causes an error when IndexOnlyScan is used  (Anastasia Lubennikova <a.lubennikova@postgrespro.ru>)
List pgsql-hackers
Hi Anastasia,

> I'd like to propose the patch that fixes the issue.
> We already have a way to return heaptuple from IndexOnlyScan,
> but it was not applied to b-tree for some reason.
>
> Attached patch solves the reported bug.
> Moreover, it will come in handy for "index with included attributes" feature
> [1],
> where we can store long (and even TOASTed) attributes in indextuple.
>
> [1] https://commitfest.postgresql.org/17/1350/

I believe the patch should include a test that tries to reproduce an
issue it tries to fix.

Also maybe this code that repeats 3 times can be moved to a separate
procedure?

--
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: unique indexes on partitioned tables
Next
From: Fabien COELHO
Date:
Subject: Re: pgbench - allow to specify scale as a size