Re: [HACKERS] Add support for tuple routing to foreign partitions - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: [HACKERS] Add support for tuple routing to foreign partitions
Date
Msg-id 20180125143338.GJ2416@tamriel.snowman.net
Whole thread Raw
In response to Re: [HACKERS] Add support for tuple routing to foreign partitions  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: [HACKERS] Add support for tuple routing to foreign partitions
List pgsql-hackers
Etsuro,

* Etsuro Fujita (fujita.etsuro@lab.ntt.co.jp) wrote:
> (2017/12/18 23:25), Alvaro Herrera wrote:
> >InitResultRelInfo becomes unintelligible after this patch -- it was
> >straightforward but adding partition_root makes things shaky.  Please
> >add a proper comment indicating what each argument is.
>
> I was thiking that the comment I added to the definition of the
> ResultRelInfo struct in execnodes.h would make that function intelligible,
> but I agree on that point.  Please fined attached a new version of the patch
> adding such comments.

I'm afraid a good bit of this patch is now failing to apply.  I don't
have much else to say except to echo the performance concern that Amit
Langote raised about expanding the inheritence tree twice.

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index
Next
From: Robert Haas
Date:
Subject: Re: Foreign keys and partitioned tables