Re: [HACKERS] Log LDAP "diagnostic messages"? - Mailing list pgsql-hackers

From Christoph Berg
Subject Re: [HACKERS] Log LDAP "diagnostic messages"?
Date
Msg-id 20170815160807.qpjvk4ta5iuudezh@msg.df7cb.de
Whole thread Raw
In response to Re: [HACKERS] Log LDAP "diagnostic messages"?  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: [HACKERS] Log LDAP "diagnostic messages"?  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Re: Thomas Munro 2017-08-10 <CAEepm=09jnV7hK5rTxPp816bMuve7dJGbjtEcjeXrhAELHFxqw@mail.gmail.com>
> > Agreed.  Here's a version that skips those useless detail messages
> > using a coding pattern I found elsewhere.
> 
> Rebased after bf6b9e94.

> message ? errdetail("Diagnostic message: %s", message) : 0));

"Diagnostic message" doesn't really mean anything, and printing
"DETAIL: Diagnostic message: <something>" seems redundant to me. Maybe
drop that prefix? It should be clear from the context that this is a
message from the LDAP layer.

Or maybe simply append ": <message>" to the error message already shown?

Christoph



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] [BUGS] Replication to Postgres 10 on Windows is broken
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Partition-wise join for join between (declaratively)partitioned tables