Re: [COMMITTERS] pgsql: Assert that we don't invent relfilenodes ortype OIDs in binary - Mailing list pgsql-committers

On Tue, Jun 13, 2017 at 01:39:34PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Uh, is there a reason this is only an Assert(), meaning it only checks
> > in assert builds.  pg_upgrade already has a lot of checks and they are
> > all fatal.
>
> Yeah, I didn't think it was worth adding overhead to production builds
> for it.

Uh, you realize there are already many pg_upgrade sanity checks in the
backend that are not asserts, right?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +