Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, soculicidae is *still* broken) - Mailing list pgsql-hackers

From Noah Misch
Subject Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, soculicidae is *still* broken)
Date
Msg-id 20170602062258.GD1500331@rfd.leadboat.com
Whole thread Raw
In response to Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, so culicidaeis *still* broken)  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Fri, May 26, 2017 at 05:50:45PM +0530, Amit Kapila wrote:
> On Fri, May 26, 2017 at 5:30 AM, Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com> wrote:
> >  I guessed that the reason Noah suggested 1 - 5 seconds of retry is based on the expectation that the address space
mightbe freed by the anti-virus software.
 

No, I suggested it because I wouldn't seriously consider keeping an
installation where backend start takes 5s.  If the address conflicts are that
persistent, I'd fix the bug or switch operating systems.  Therefore, we may as
well let it fail at that duration, thereby showing the user what to
investigate.  Startup time of 0.2s, on the other hand, is noticeable but
usable; I'd prefer not to fail hard at that duration.

> Noah is also suggesting to have a retry count, read his mail above in
> this thread and refer to his comment ("Thus, measuring time is
> needless complexity; retry count is a suitable proxy.")

Right.



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Race conditions with WAL sender PID lookups
Next
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] Why does logical replication launcher set application_name?