Re: [HACKERS] ECPG: pg_type.h file is not synced - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] ECPG: pg_type.h file is not synced
Date
Msg-id 20170530204242.GA11362@momjian.us
Whole thread Raw
In response to Re: [HACKERS] ECPG: pg_type.h file is not synced  (Michael Meskes <meskes@postgresql.org>)
Responses Re: [HACKERS] ECPG: pg_type.h file is not synced  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, May 23, 2017 at 10:25:13AM +0200, Michael Meskes wrote:
> Hi,
> 
> > I am looking at ECPG source code. In the "ecpg/ecpglib/pg_type.h" file I
> > have seen following comment:
> > 
> > ** keep this in sync with src/include/catalog/pg_type.h*
> > 
> > But I think the "ecpg/ecpglib/pg_type.h" file is currently not synced
> > with the above file.
> > 
> > I have added the remaining types in the attached patch.
> > 
> > I would like to know whether we can add remaining types in the
> > "ecpg/ecpglib/pg_type.h" file or not?
> 
> It's not too big a deal as neither of the new OIDs is used in ecpg, but
> still, the file should be up to date.
> 
> Thanks for the patch, committed.

Should we add some Makefile magic to make sure they stay in sync?

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] ECPG: pg_type.h file is not synced