[COMMITTERS] Re: pgsql: Code review focused on new node types added bypartitioning supp - Mailing list pgsql-committers

From Noah Misch
Subject [COMMITTERS] Re: pgsql: Code review focused on new node types added bypartitioning supp
Date
Msg-id 20170530023217.GA139553@gust.leadboat.com
Whole thread Raw
In response to [COMMITTERS] pgsql: Code review focused on new node types added by partitioningsupp  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Mon, May 29, 2017 at 03:20:41AM +0000, Tom Lane wrote:
> Annotate the fact that somebody added location fields to PartitionBoundSpec
> and PartitionRangeDatum but forgot to handle them in
> outfuncs.c/readfuncs.c.  This is fairly harmless for production purposes
> (since readfuncs.c would just substitute -1 anyway) but it's still bogus.
> It's not worth forcing a post-beta1 initdb just to fix this, but if we
> have another reason to force initdb before 10.0, we should go back and
> clean this up.

+1 for immediately forcing initdb for this, getting it out of the way.  We're
already unlikely to reach 10.0 without bumping catversion, but if we otherwise
did, releasing 10.0 with a 10beta1 catversion would have negative value.


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix improper quoting of format_type_be() output.
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix omission of locations in outfuncs/readfuncs partitioningnod