Re: [HACKERS] Bug in ExecModifyTable function and trigger issuesfor foreign tables - Mailing list pgsql-hackers

From Ildus Kurbangaliev
Subject Re: [HACKERS] Bug in ExecModifyTable function and trigger issuesfor foreign tables
Date
Msg-id 20170515121638.0c076bcc@wp.localdomain
Whole thread Raw
In response to Re: [HACKERS] Bug in ExecModifyTable function and trigger issues forforeign tables  (Dilip Kumar <dilipbalaut@gmail.com>)
Responses Re: [HACKERS] Bug in ExecModifyTable function and trigger issues forforeign tables  (Dilip Kumar <dilipbalaut@gmail.com>)
Re: [HACKERS] Bug in ExecModifyTable function and trigger issues forforeign tables  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers
On Mon, 15 May 2017 10:34:58 +0530
Dilip Kumar <dilipbalaut@gmail.com> wrote:

> On Sun, May 14, 2017 at 9:54 PM, Dilip Kumar <dilipbalaut@gmail.com>
> wrote:
> > After your fix, now tupleid is invalid which is expected, but seems
> > like we need to do something more. As per the comments seems like it
> > is expected to get the oldtuple from planSlot.  But I don't see any
> > code for handling that part.  
> 
> Maybe we should do something like attached patch.
> 

Hi,
planSlot contains already projected tuple, you can't use it as oldtuple.
I think problem is that `rewriteTargetListUD` called only for parent
relation, so there is no `wholerow` attribute for foreign tables.

-- 
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] Typos in pg_basebackup.c
Next
From: Heikki Linnakangas
Date:
Subject: Re: [HACKERS] Receive buffer size for the statistics socket