Re: [HACKERS] GCC 7 warnings - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [HACKERS] GCC 7 warnings
Date
Msg-id 20170410153524.GA13447@e733.localdomain
Whole thread Raw
In response to [HACKERS] GCC 7 warnings  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Hi Peter,

> c) Expand the target buffer sizes until the warning goes away.  (Sample
> patch attached.)

I personally think it's a great patch. Unfortunately I don't have GCC
7.0 right now but at least it doesn't break anything on 6.3.1. Since
there is no rush I would suggest to add an entry to the next commitfest,
so this patch wouldn't accidentally be lost.

As a side node I believe it would be great to replace all sprintf calls
to snprintf just to be on a safe side. IIRC we did something similar to
str* procedures not a long time ago. Unless there are any objections
regarding this idea I'm willing to write such a patch.

--
Best regards,
Aleksander Alekseev

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] RMT: Use Visual Studio 2015 for Compiling and linkingthe Windows version in PG10
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Merge join for GiST