Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_upgrade: exit_hook_registered variable - Mailing list pgsql-hackers

From Kyotaro HORIGUCHI
Subject Re: pg_upgrade: exit_hook_registered variable
Date
Msg-id 20160728.192100.59056316.horiguchi.kyotaro@lab.ntt.co.jp
Whole thread Raw
In response to pg_upgrade: exit_hook_registered variable  (Artur Zakirov <a.zakirov@postgrespro.ru>)
Responses Re: pg_upgrade: exit_hook_registered variable
List pgsql-hackers
Tree view 
Hello,

> I noticed that exit_hook_registered variable in start_postmaster() is
> local variable. Shouldn't it be a static variable?
> 
> I attached a patch. Thank you!

Good catch! It is totally useless unless being static.

But I think it is not necessary to go outside
start_postmaster. Just being static staying in start_postmaster
is enough.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Wrong defeinition of pq_putmessage_noblock since 9.5
Next
From: Geoff Winkless
Date:
Subject: Re: Why we lost Uber as a user