Re: ALTER TABLE lock downgrades have broken pg_upgrade - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: ALTER TABLE lock downgrades have broken pg_upgrade
Date
Msg-id 20160503172153.GO10850@tamriel.snowman.net
Whole thread Raw
In response to Re: ALTER TABLE lock downgrades have broken pg_upgrade  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: ALTER TABLE lock downgrades have broken pg_upgrade  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: ALTER TABLE lock downgrades have broken pg_upgrade  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
* Alvaro Herrera (alvherre@2ndquadrant.com) wrote:
> Tom Lane wrote:
>
> > More generally, though, I wonder how we can have some test coverage
> > on such cases going forward.  Is the patch below too ugly to commit
> > permanently, and if so, what other idea can you suggest?
>
> I suggest a buildfarm animal running a custom buildfarm module that
> exercises the pg_upgrade test from every supported version to the latest
> stable and to master -- together with your proposed case that leaves a
> toastless table around for pg_upgrade to handle.

That would help greatly with pg_dump test coverage as well..  One of the
problems of trying to get good LOC coverage of pg_dump is that a *lot*
of the code is version-specific...

Thanks!

Stephen

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: what to revert
Next
From: Alvaro Herrera
Date:
Subject: Re: ALTER TABLE lock downgrades have broken pg_upgrade