Re: ALTER TABLE lock downgrades have broken pg_upgrade - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: ALTER TABLE lock downgrades have broken pg_upgrade
Date
Msg-id 20160503170828.GA31385@alvherre.pgsql
Whole thread Raw
In response to ALTER TABLE lock downgrades have broken pg_upgrade  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: ALTER TABLE lock downgrades have broken pg_upgrade  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Tom Lane wrote:

> More generally, though, I wonder how we can have some test coverage
> on such cases going forward.  Is the patch below too ugly to commit
> permanently, and if so, what other idea can you suggest?

I suggest a buildfarm animal running a custom buildfarm module that
exercises the pg_upgrade test from every supported version to the latest
stable and to master -- together with your proposed case that leaves a
toastless table around for pg_upgrade to handle.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: what to revert
Next
From: Peter Geoghegan
Date:
Subject: Re: what to revert