Postgres Pro
Downloads
Home   >   mailing lists

Small patch: Change calling convention for ShmemInitHash (and fix possible bug) - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Small patch: Change calling convention for ShmemInitHash (and fix possible bug)
Date
Msg-id 20160324165045.1b4eb1a0@fujitsu
Whole thread Raw
Responses Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)
List pgsql-hackers
Tree view 
Hello

I would like to continue discussion regarding changing calling
convention for ShmemInitHash procedure:

http://www.postgresql.org/message-id/CA+TgmoZm=Uowt8a_XaSfooGwufeeLJ861NTADiCEOpyFehV8Wg@mail.gmail.com

Currently this procedure has two arguments --- init_size and max_size.
But since shared hash tables have fixed size there is little sense to
pass two arguments. In fact currently ShmemInitHash is always called
with init_size == max_size with only one exception, InitLocks procedure
(see lock.c), which I believe is actually a bug.

Patch is attached.

What do you think?

--
Best regards,
Aleksander Alekseev
http://eax.me/
Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Support for N synchronous standby servers - take 2
Next
From: Konstantin Knizhnik
Date:
Subject: avg,first,last,median in one query