Re: Template for commit messages - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Template for commit messages
Date
Msg-id 20160128163128.GE20574@momjian.us
Whole thread Raw
In response to Re: Template for commit messages  (Stephen Frost <sfrost@snowman.net>)
Responses Re: Template for commit messages  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
On Thu, Jan 28, 2016 at 10:40:09AM -0500, Stephen Frost wrote:
> * Joshua D. Drake (jd@commandprompt.com) wrote:
> > On 01/28/2016 06:57 AM, Robert Haas wrote:
> > 
> > >>I'm on board with Bruce's template as being a checklist of points to be
> > >>sure to cover when composing a commit message.  I'm not sure we need
> > >>fixed-format rules.
> > >
> > >Well, I think what people are asking for is precisely a fixed format,
> > >and I do think there is value in that.  It's nice to capture the
> > >nuance, but the nuance is going to get flattened out anyway when the
> > >release notes are created.  If we all agree to use a fixed format,
> > >then a bunch of work there that probably has to be done manually can
> > >be automated.  However, if we all agree to use a fixed format except
> > >for you, we might as well just forget the whole thing, because the
> > >percentage of commits that are done by you is quite high.
> > 
> > Yes, we are either all in or we may as well forgo this.
> 
> I don't have a particular issue with it, but would like whatever
> template is decided upon to be included in our git repo and then we
> should be able to make it the template that's opened up when people go
> to commit pretty easily.

OK, but keep in mind whatever script committers user should remove tags
that are empty after exiting the editor.  I can provide the grep regex
in git somewhere too:
 egrep -v "^(Author|Reported-by|Bug|Reviewed-by|Tested-by|Backpatch-through): *$"

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Roman grave inscription                             +



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: CustomScan under the Gather node?
Next
From: Robert Haas
Date:
Subject: Re: tiny doc patch