Re: pg_receivexlog: spurious error message connecting to 9.3 - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pg_receivexlog: spurious error message connecting to 9.3
Date
Msg-id 20160105202739.GA317326@alvherre.pgsql
Whole thread Raw
In response to Re: pg_receivexlog: spurious error message connecting to 9.3  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Michael Paquier wrote:
> On Mon, Dec 7, 2015 at 11:37 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> 
> > The latest patch has another problem; pg_receivexlog trying to connect to
> > the PostgreSQL >= 9.4 always reports the following message unexpectedly.
> >
> > could not identify system: got 1 rows and 4 fields, expected 1 rows
> > and 4 or more fields
> >
> > This problem happens because the patch incorrectly treats the case where
> > IDENTIFY_SYSTEM command returns NULL as database name, as an error case.
> >
> > Attached is the updated version of the patch, which fixes the problem.
> > Comments?
> 
> The patch looks good. The top comment of RunIdentifySystem is incorrect
> though. It should mention that a database name is returned and not a plugin
> name.

Right.  Pushed with that change to 9.5 and master.  Thanks!

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Beginner hacker item: Fix to_reg*() input type
Next
From: Tom Lane
Date:
Subject: Re: Building pg_xlogdump reproducibly