Re: Beginner hacker item: Fix to_reg*() input type - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Beginner hacker item: Fix to_reg*() input type
Date
Msg-id 11476.1452023095@sss.pgh.pa.us
Whole thread Raw
In response to Re: Beginner hacker item: Fix to_reg*() input type  (Petr Korobeinikov <pkorobeinikov@gmail.com>)
List pgsql-hackers
Petr Korobeinikov <pkorobeinikov@gmail.com> writes:
> 2016-01-05 21:04 GMT+03:00 Tom Lane <tgl@sss.pgh.pa.us>:
>> (I did make some small adjustments --- in this usage, PG_GETARG_TEXT_PP
>> is good enough and likely a bit more efficient than PG_GETARG_TEXT_P.)

> Also I forgot to bump catalog version up. My mishit.

No, submitted patches generally should not touch catversion (though it's
not a bad idea to mention the need for a bump in the submission message).
If you put in a catversion change, it's generally just going to cause
merge failures, since patches seldom get applied instantly.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Petr Korobeinikov
Date:
Subject: Re: Beginner hacker item: Fix to_reg*() input type
Next
From: Alvaro Herrera
Date:
Subject: Re: pg_receivexlog: spurious error message connecting to 9.3