Re: BRIN INDEX value - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: BRIN INDEX value
Date
Msg-id 20150905.094604.2231229768212176147.t-ishii@sraoss.co.jp
Whole thread Raw
In response to Re: BRIN INDEX value  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: BRIN INDEX value
List pgsql-hackers
> Tatsuo Ishii wrote:
>> > On 9/4/2015 2:04 PM, Tatsuo Ishii wrote:
>> >>> One thing I imagine we could do is to change the signature of
>> >>> summrize_range() to also include heapNumBlks which its (only) caller
>> >>> brinsummarize() already computes. It will look like:
>> >>>
>> >>> static void summarize_range(IndexInfo *indexInfo, BrinBuildState *state,
>> >>>                               Relation heapRel,
>> >>>                               BlockNumber heapBlk,
>> >>>                               BlockNumber heapNumBlks);
>> >>>
>> >>> I'd think changing summarize_range()'s signature would be relatively
>> >>> easier/safer.
>> >> 
>> >> Yeah, sounds good.
>> > 
>> > Here's a patch to do that.
>> 
>> Thanks. It looks good to me (and passed all the regression tests in
>> master branch). I will commit your patch if there's no objection.
> 
> Yeah, thanks, please go ahead.

Thanks. Fix committed.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: WIP: SCRAM authentication
Next
From: Amit Langote
Date:
Subject: Re: BRIN INDEX value