Re: fsync-pgdata-on-recovery tries to write to more files than previously - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: fsync-pgdata-on-recovery tries to write to more files than previously
Date
Msg-id 20150526105342.GW26667@tamriel.snowman.net
Whole thread Raw
In response to Re: fsync-pgdata-on-recovery tries to write to more files than previously  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
List pgsql-hackers
* Abhijit Menon-Sen (ams@2ndQuadrant.com) wrote:
> At 2015-05-26 03:54:51 +0200, andres@anarazel.de wrote:
> > Another thing is whether we should handle a recursive symlink in
> > pgdata? I personally think not, but...
>
> I think not too.

Yikes..  That's definitely the kind of thing that's why I worry about
the whole 'fsync everything' idea- what if I symlink to /?  I've
certainly done that before from my home directory for ease of use and I
imagine there are people out there who have similar setups where they
sftp as the PG user and use the symlink to more easily navigate
somewhere else.  We have to realize that, on at least some systems,
PGDATA could be the postgres user's home directory too.  That's not the
case on Debian-based systems today, but I think it might have been
before Debian had the multi-cluster tooling.

> > It's also not just as simple as making fsync_fname fail gracefully
> > upon EACCESS - the opendir() could fail just as well.
>
> I'll post a proposed patch shortly.

Thanks!
Stephen

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Order of columns in query is important?!
Next
From: Uriy Zhuravlev
Date:
Subject: Selectivity estimation for intarray with @@