Re: fsync-pgdata-on-recovery tries to write to more files than previously - Mailing list pgsql-hackers

From Abhijit Menon-Sen
Subject Re: fsync-pgdata-on-recovery tries to write to more files than previously
Date
Msg-id 20150526045635.GA20076@toroid.org
Whole thread Raw
In response to Re: fsync-pgdata-on-recovery tries to write to more files than previously  (Andres Freund <andres@anarazel.de>)
Responses Re: fsync-pgdata-on-recovery tries to write to more files than previously
List pgsql-hackers
At 2015-05-26 03:54:51 +0200, andres@anarazel.de wrote:
>
> Say a symlink goes to a binary, which is currently being executed:
> ETXTBSY. Or the file is in a readonly filesystem: EROFS.  So we'd
> need to ignore a lot of errors, possibly ignoring valid ones.

Right. That's why I started out by being conservative and following only
the "expected" symlinks in pg_tblspc (as other parts of the code do).

> Another thing is whether we should handle a recursive symlink in
> pgdata? I personally think not, but...

I think not too.

> It's also not just as simple as making fsync_fname fail gracefully
> upon EACCESS - the opendir() could fail just as well.

I'll post a proposed patch shortly.

-- Abhijit



pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: fsync bug faq for publication?
Next
From: Tom Lane
Date:
Subject: Re: fsync bug faq for publication?