Re: POLA violation with \c service= - Mailing list pgsql-hackers

From David Fetter
Subject Re: POLA violation with \c service=
Date
Msg-id 20150227164229.GA4014@fetter.org
Whole thread Raw
In response to Re: POLA violation with \c service=  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: POLA violation with \c service=  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: POLA violation with \c service=  (David Fetter <david@fetter.org>)
Re: POLA violation with \c service=  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Mon, Feb 23, 2015 at 05:56:12PM -0300, Alvaro Herrera wrote:
>
> David Fetter wrote:
>
> > My thinking behind this was that the patch is a bug fix and intended
> > to be back-patched, so I wanted to mess with as little infrastructure
> > as possible.  A new version of libpq seems like a very big ask for
> > such a case.  You'll recall that the original problem was that
> >
> >     \c service=foo
> >
> > only worked accidentally for some pretty narrow use cases and broke
> > without much of a clue for the rest.  It turned out that the general
> > problem was that options given to psql on the command line were not
> > even remotely equivalent to \c, even though they were documented to
> > be.
>
> So, in view of these arguments and those put forward by Pavel
> downthread, I think the attached is an acceptable patch for the master
> branch.  It doesn't apply to back branches though; 9.4 and 9.3 have a
> conflict in tab-complete.c, 9.2 has additional conflicts in command.c,
> and 9.1 and 9.0 are problematic all over because they don't have
> src/common.  Could you please submit patches adapted for each group of
> branches?

Please find patches attached for each live branch.

Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Providing catalog view to pg_hba.conf file - Patch submission
Next
From: Stephen Frost
Date:
Subject: Re: Providing catalog view to pg_hba.conf file - Patch submission