Re: Final Patch for GROUPING SETS - Mailing list pgsql-hackers

From Noah Misch
Subject Re: Final Patch for GROUPING SETS
Date
Msg-id 20141223072958.GB1900132@tornado.leadboat.com
Whole thread Raw
In response to Re: Final Patch for GROUPING SETS  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Final Patch for GROUPING SETS  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
On Mon, Dec 22, 2014 at 10:46:16AM -0500, Tom Lane wrote:
> I still find the ChainAggregate approach too ugly at a system structural
> level to accept, regardless of Noah's argument about number of I/O cycles
> consumed.  We'll be paying for that in complexity and bugs into the
> indefinite future, and I wonder if it isn't going to foreclose some other
> "performance opportunities" as well.

Among GROUPING SETS GroupAggregate implementations, I bet there's a nonempty
intersection between those having maintainable design and those having optimal
I/O usage, optimal memory usage, and optimal number of sorts.  Let's put more
effort into finding it.  I'm hearing that the shared tuplestore is
ChainAggregate's principal threat to system structure; is that right?



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: moving from contrib to bin
Next
From: Noah Misch
Date:
Subject: Re: Initdb-cs_CZ.WIN-1250 buildfarm failures