Re: no test programs in contrib - Mailing list pgsql-hackers

From Andres Freund
Subject Re: no test programs in contrib
Date
Msg-id 20141124143540.GC31915@alap3.anarazel.de
Whole thread Raw
In response to no test programs in contrib  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: no test programs in contrib  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Hi,

On 2014-11-24 10:49:45 -0300, Alvaro Herrera wrote:
> I'm now contemplating the addition on a new one in the commit-timestamps
> patch, and I'm starting to feel that these are all misplaced.  I think
> we have been dumping them to contrib not because they really belong
> there, but because of the lack of a better place.

Agreed.

> As opposed to the
> rest of the stuff in contrib/, they don't serve any useful purpose on
> themselves; they are just demonstrating some coding techniques, or
> testing that some framework work as intended.

I actually think that test_decoding is somewhat useful in other cases as
well, so it might be prudent to leave it there.

> What would you say if we were to move them to src/test/?  I could also
> see putting them in a brand new top-level directory, say testing/ or
> testprg/.

src/test/ is good, but I think there should be another subdirectory
inside. testcases/?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Turning recovery.conf into GUCs
Next
From: Christoph Berg
Date:
Subject: Re: test_shm_mq failing on anole (was: Sending out a request for more buildfarm animals?)