On 2014-07-16 10:43:08 +0900, Shigeru Hanada wrote:
> Kaigai-san,
>
> 2014-07-15 21:37 GMT+09:00 Kouhei Kaigai <kaigai@ak.jp.nec.com>:
> > Sorry, expected result of sanity-check test was not updated on
> > renaming to pg_custom_plan_provider.
> > The attached patch fixed up this point.
>
> I confirmed that all regression tests passed, so I marked the patch as
> "Ready for committer".
I personally don't see how this patch is 'ready for committer'. I
realize that that state is sometimes used to denote that review needs to
be "escalated", but it still seemspremature.
Unless I miss something there hasn't been any API level review of this?
Also, aren't there several open items?
Perhaps there needs to be a stage between 'needs review' and 'ready for
committer'?
Greetings,
Andres Freund
-- Andres Freund http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services
