Re: -DDISABLE_ENABLE_ASSERT - Mailing list pgsql-hackers

From Andres Freund
Subject Re: -DDISABLE_ENABLE_ASSERT
Date
Msg-id 20140523135952.GI31579@alap3.anarazel.de
Whole thread Raw
In response to Re: -DDISABLE_ENABLE_ASSERT  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: -DDISABLE_ENABLE_ASSERT  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2014-05-23 09:56:03 -0400, Tom Lane wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > On Fri, May 23, 2014 at 8:15 AM, Andres Freund <andres@2ndquadrant.com> wrote:
> >> That means you're for a (differently named) disable macro? Or is it not
> >> recent enough that you don't care?
> 
> > I'm leaning toward thinking we should just rip it out.  The fact that
> > 3 out of the 4 people commenting on this thread have used it at some
> > point provides some evidence that it has more than no value - but on
> > the other hand, there's a cost to keeping it around.
> 
> Yeah.  For the record, I've used it too (don't recall what for exactly).
> But I don't think it's worth adding yet another layer of complication for.

Cool. Seems like we have an agreement then.

The next question is whether to wait till after the branching with this?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: -DDISABLE_ENABLE_ASSERT
Next
From: Tom Lane
Date:
Subject: Re: -DDISABLE_ENABLE_ASSERT