Re: FastPathStrongRelationLocks still has an issue in HEAD - Mailing list pgsql-hackers

From Andres Freund
Subject Re: FastPathStrongRelationLocks still has an issue in HEAD
Date
Msg-id 20140407142022.GB4161@awork2.anarazel.de
Whole thread Raw
In response to Re: FastPathStrongRelationLocks still has an issue in HEAD  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: FastPathStrongRelationLocks still has an issue in HEAD
List pgsql-hackers
On 2014-04-07 10:06:07 -0400, Robert Haas wrote:
> I'm a bit suspicious of the patches to
> static-ify stuff, since that might cause the compiler to think it
> could move things across function calls that it hadn't thought
> move-able before, but FastPathStrongLocks references would seem to be
> the obvious candidate for that, and volatile-izing it ought to have
> fixed it.  I would think.

Hm. It generally might be interesting to get a few !X86 buildfarms
running builds with LTO enabled. That might expose some dangerous
assumptions more easily.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Mike Blackwell
Date:
Subject: Re: tds_fdw for Sybase and MS SQL Server
Next
From: Andres Freund
Date:
Subject: Re: Windows exit code 128 ... it's baaack