Re: Useless "Replica Identity: NOTHING" noise from psql \d - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Useless "Replica Identity: NOTHING" noise from psql \d
Date
Msg-id 20140324160306.GB15836@momjian.us
Whole thread Raw
In response to Re: Useless "Replica Identity: NOTHING" noise from psql \d  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, Mar 23, 2014 at 11:49:37AM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Is this the patch you had in mind?  I kept the pg_catalog filter.  Do we
> > want to always show the replica identity line for \d+?
>
> Doesn't seem like a great idea to remove the filter tests for replident
> values and then not fix the display code to cope with those values.
>
> I think this display code is well south of minimal acceptability anyhow:
> if the column contains anything other than what it expects, it will print
> a lie, meaning it's entirely not future-proof.  I'd suggest a switch()
> that prints "???" in the default: case.

Oh, good points.  I have updated the attached patch.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +

Attachment

pgsql-hackers by date:

Previous
From: "MauMau"
Date:
Subject: Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation
Next
From: Andres Freund
Date:
Subject: Re: Useless "Replica Identity: NOTHING" noise from psql \d