Re: Custom Scan APIs (Re: Custom Plan node) - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: Custom Scan APIs (Re: Custom Plan node)
Date
Msg-id 20140226080340.GG2921@tamriel.snowman.net
Whole thread Raw
In response to Re: Custom Scan APIs (Re: Custom Plan node)  (Shigeru Hanada <shigeru.hanada@gmail.com>)
List pgsql-hackers
* Shigeru Hanada (shigeru.hanada@gmail.com) wrote:
> Perhaps he meant to separate patches based on feature-based rule.  IMO
> if exposing utilities is essential for Custom Scan API in practical
> meaning, IOW to implement and maintain an extension which implements
> Custom Scan API, they should be go into the first patch.  IIUC two
> contrib modules are also PoC for the API, so part-2/3 patch should
> contain only changes against contrib and its document.

That's what I was getting at, yes.

> Besides that, some typo fixing are mixed in part-2 patch.  They should
> go into the part-1 patch where the typo introduced.

Agreed.
THanks,
    Stephen

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Custom Scan APIs (Re: Custom Plan node)
Next
From: Dimitri Fontaine
Date:
Subject: Re: extension_control_path