Robert Haas escribió:
> On Wed, Oct 30, 2013 at 4:51 AM, David Rowley <dgrowleyml@gmail.com> wrote:
> > I've attached a re-based version of this.
>
> I don't see any compelling reason not to commit this. Does anyone
> wish to object?
I think a blanket substitution of places that currently have %s might
cause bugs, particularly if the string is user-supplied. It might be
right for many cases, but did you/someone review each such callsite?
No objection to the other half, that substitute calls that don't have
%s.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
