Re: Enabling frontend-only xlog "desc" routines - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Enabling frontend-only xlog "desc" routines
Date
Msg-id 20121129200946.GB29711@awork2.anarazel.de
Whole thread Raw
In response to Re: Enabling frontend-only xlog "desc" routines  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2012-11-29 15:03:48 -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > The other interesting question remaining is what to do about the rm_desc
> > function in rmgr.c.  We're split between these two ideas:
>
> Why try to link rmgr.c into frontend versions at all?  Just make
> a new table file that only includes the desc function pointers.
> Yeah, then there would be two table files to maintain, but it's
> not clear to me that it's uglier than these proposals ...

Seems more likely to get out of sync. But then, rmgr.c isn't changing
that heavily...
I still prefer the -DFRONTEND solutions, but once more, its only a
slight preference.

Greetings,

Andres Freund

--Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Enabling frontend-only xlog "desc" routines
Next
From: Tom Lane
Date:
Subject: Re: Overlength socket paths (was Re: [COMMITTERS] pgsql: Refactor flex and bison make rules)